Implementing "withFileTypes" option for fs.readdir method #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm the maintainer of the
fast-glob
package.In my package, I try to use all possible ways to optimize the work with the file system. One of these ways is a
withFileTypes
option in thefs.readdir
method. Unfortunately, this package does not support this option. So, this pull request implements support for this option.This is a possible solution for the following issues:
My solution uses an internal implementation of the
getDirents
method fromFSReqWrap
, because I don't know how to replace callback. I will accept any suggestions if it really needs to be done.I checked that my changes are working by the following script: